-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComponentInstallers should run after LogManager if a custom one is detected #2592
ComponentInstallers should run after LogManager if a custom one is detected #2592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can keep the Java 8 condition. IIRC (and I likely do not), starting in Java 9, Java classes themselves no longer use j.u.l., instead using a new internal logging API.
// classpath. | ||
// Our solution is to delay the initialization of ComponentInstallers when we detect a custom | ||
// log manager being used. | ||
// Once we see the LogManager class loading, it's safe to run ComponentInstaller#after() because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Once we see the LogManager class loading, it's safe to run ComponentInstaller#after() because | |
// Once we see the LogManager class loading, it's safe to run ComponentInstaller#afterByteBuddyAgent() because |
@trask @mateuszrzeszutek what is the drawback of late installation of components? |
That's true, Java 9 introduced the new
Hmm, runtime/JVM metrics starting a bit later? The only risk that I can think of is that LogManager never loads and |
fa2554e
to
51d4e69
Compare
|
No, because it doesn't override the |
Fixes #2591