Let the ComponentInstaller be passed a Config instance #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Mar 12, 2021
javaagent-spi/src/main/java/io/opentelemetry/javaagent/spi/exporter/SpanExporterFactory.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Mar 13, 2021
javaagent-spi/src/main/java/io/opentelemetry/javaagent/spi/exporter/MetricServer.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Mar 16, 2021
4f6fedb to
0e45d0f
Compare
|
@breedx-splk Please rebase again. Main branch failure was fixed |
…ing Config over Properties
…th the ol' properties for now.
0e45d0f to
751f357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also prefers using the immutable Config instances over the Properties that are created from the config.
This is a breaking change for SPI implementations. I initially tried to keep both interface methods around (one that takes the config, one that doesn't) but I think that it just served to muddy up the interface.