-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename grizzly-client instrumentation #1709
Rename grizzly-client instrumentation #1709
Conversation
I think there is some confusion here. https://github.com/AsyncHttpClient/async-http-client uses artifactId The instrumentation under review monitors the second one, not the first one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment above
oh ya, |
Ok, I now understand better what is happening. But I am still not convinced this change is a good one. This instrumentation still was written for https://github.com/eclipse-ee4j/grizzly-ahc, judging from package and artifact names. Why do we want to instead say that this is about old version of https://github.com/AsyncHttpClient/async-http-client? Then we should change gradle build file and test with those artifacts, whose |
👍 done |
Closes #1658