Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "auto" to "javaagent" in modules #1370

Merged
merged 6 commits into from
Oct 13, 2020
Merged

Rename "auto" to "javaagent" in modules #1370

merged 6 commits into from
Oct 13, 2020

Conversation

trask
Copy link
Member

@trask trask commented Oct 12, 2020

Another part of #1186

This includes #1186 (comment):

Trying out shortening the name opentelemetry-javaagent-instrumentation-api --> opentelemetry-javaagent-api

But not the shortened package rename yet, because still thinking about #1186 (comment).

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Contributor

@iNikem iNikem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one question: why we have to repeat JAVAagent? Maybe just agent?

@trask
Copy link
Member Author

trask commented Oct 12, 2020

LGTM but one question: why we have to repeat JAVAagent? Maybe just agent?

I like changing it here:

  • armeria-1.0
    • javaagent -> agent
    • library
    • testing

since library in this context doesn't really correspond to package name / artifact name either.

For other places, I'm torn:

io.opentelemetry.agent

  • opentelemetry-agent-cats
  • opentelemetry-agent-api
  • opentelemetry-agent
  • opentelemetry-agent-spi
  • opentelemetry-agent-exporters-otlp
  • opentelemetry-agent-exporters-jaeger
  • opentelemetry-agent-exporters-zipkin
  • opentelemetry-agent-exporters-logging
  • Internal components of the agent (maybe we don't need to publish?)
    • opentelemetry-agent-internal-bootstrap
    • opentelemetry-agent-internal-tooling

I like the shorter agent, but also we were trying to avoid confusion with external agents, e.g. OpenTelemetry collector agent.

@iNikem
Copy link
Contributor

iNikem commented Oct 12, 2020

Does anybody call Otel Collector an "agent"?

@trask
Copy link
Member Author

trask commented Oct 12, 2020

Does anybody call Otel Collector an "agent"?

Yeah, https://opentelemetry.io/docs/collector/about/

Also, when most ops people hear "agent", they think of out-of-process agent (like the collector agent), as opposed to in-process agent (like a javaagent). Some discussion about this occurred here: https://github.com/open-telemetry/oteps/blob/master/text/0001-telemetry-without-manual-instrumentation.md

@iNikem
Copy link
Contributor

iNikem commented Oct 12, 2020

Let it be "javaagent" then

@trask trask merged commit 7ecc9bb into open-telemetry:master Oct 13, 2020
@trask trask deleted the rename-modules branch October 13, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants