-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "auto" to "javaagent" in modules #1370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but one question: why we have to repeat JAVAagent
? Maybe just agent
?
I like changing it here:
since For other places, I'm torn: io.opentelemetry.agent
I like the shorter |
Does anybody call Otel Collector an "agent"? |
Yeah, https://opentelemetry.io/docs/collector/about/ Also, when most ops people hear "agent", they think of out-of-process agent (like the collector agent), as opposed to in-process agent (like a javaagent). Some discussion about this occurred here: https://github.com/open-telemetry/oteps/blob/master/text/0001-telemetry-without-manual-instrumentation.md |
Let it be "javaagent" then |
Another part of #1186
This includes #1186 (comment):
But not the shortened package rename yet, because still thinking about #1186 (comment).