Do not merge/review! Reproducer for: Muzzle does not check abstract method at runtime #1354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer for #1337.
Steps to reproduce:
And sample app, cone https://github.com/pavolloffay/sample-apps/tree/traceable
Now search for
Server exception at doPost: java.lang.AbstractMethodError: Missing implementation of resolved method 'abstract boolean isReady()' of abstract class javax.servlet.ServletInputStream.
in the stdout.The issue is in this class https://github.com/pavolloffay/opentelemetry-auto-instr-java/blob/muzzle-runtime-abstract-method/instrumentation/servlet/servlet-3.0/src/main/java/io/opentelemetry/instrumentation/auto/servlet/v3_0/bodycapture/BufferingHttpServletRequest.java#L254. The muzzle fails the build correctly but does not recognize API mismatch at runtime and the instrumentation is loaded.