Run class load listener only once #12565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #12444 we set up byte buddy twice. First before otel sdk is built we set up some virtual field transforms so that classes loaded during otel sdk initialization wouldn't need to use fallback map for virtual fields. Later when otel sdk is built we set up rest of the transforms. This PR removes class load listener from early byte buddy instance to ensure that class load listeners are triggered only once. Currently on wildfly where running after agent listeners is triggered by loading
java.util.logging.LogManager
(see https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java#L309) class load listener forjava.util.logging.LogManager
is triggered twice which causes a lot of warnings like