Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain instrumentation does not record exception in many tests #807

Closed
anuraaga opened this issue Jul 27, 2020 · 1 comment · Fixed by #4677
Closed

Certain instrumentation does not record exception in many tests #807

anuraaga opened this issue Jul 27, 2020 · 1 comment · Fixed by #4677

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Jul 27, 2020

Grizzly does not seem to record exception in many tests. Need to confirm this is expected, for now I have added testException() return false without knowing if this is precise or not.

Vertx as well.

Probably same reason as Vertx but Netty too. Exception is literally caught by the test and translated into HTTP so doesn't seem to really test anything (presumably instrumentation should be doing something like what the test is doing)

Servlet Async too, there seems to be no way of completing an async context with a throwable. Our tests just throw the exception without it being handled by the instrumentation.

@anuraaga
Copy link
Contributor Author

My guess is this and #806 will be solved at the same time, those loose assertions allowed these to pass in the first place from what I can tell.

@anuraaga anuraaga changed the title Grizzly does not record exception in many tests Certain instrumentation does not record exception in many tests Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants