You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Grizzly does not seem to record exception in many tests. Need to confirm this is expected, for now I have added testException() return false without knowing if this is precise or not.
Vertx as well.
Probably same reason as Vertx but Netty too. Exception is literally caught by the test and translated into HTTP so doesn't seem to really test anything (presumably instrumentation should be doing something like what the test is doing)
Servlet Async too, there seems to be no way of completing an async context with a throwable. Our tests just throw the exception without it being handled by the instrumentation.
The text was updated successfully, but these errors were encountered:
My guess is this and #806 will be solved at the same time, those loose assertions allowed these to pass in the first place from what I can tell.
anuraaga
changed the title
Grizzly does not record exception in many tests
Certain instrumentation does not record exception in many tests
Jul 27, 2020
Grizzly does not seem to record exception in many tests. Need to confirm this is expected, for now I have added
testException() return false
without knowing if this is precise or not.Vertx as well.
Probably same reason as Vertx but Netty too. Exception is literally caught by the test and translated into HTTP so doesn't seem to really test anything (presumably instrumentation should be doing something like what the test is doing)
Servlet Async too, there seems to be no way of completing an async context with a throwable. Our tests just throw the exception without it being handled by the instrumentation.
The text was updated successfully, but these errors were encountered: