Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspicious assertion - "error.*" { it == null || foo } #806

Closed
anuraaga opened this issue Jul 27, 2020 · 0 comments · Fixed by #813
Closed

Suspicious assertion - "error.*" { it == null || foo } #806

anuraaga opened this issue Jul 27, 2020 · 0 comments · Fixed by #813

Comments

@anuraaga
Copy link
Contributor

I've noticed some suspicious assertions recently and will file issues when I file.

HttpServerTest checks error attributes but has a it == null fallback in the assertions. This seems imprecise and can hide real bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants