Change to release after SDK and before Instrumentation #1581
Conversation
| @@ -12,9 +12,9 @@ as the last step, which publishes a snapshot build to | |||
|
|
|||
| ## Release cadence | |||
|
|
|||
| This repository roughly targets monthly minor releases from the `main` branch on the Friday after | |||
| This repository roughly targets monthly minor releases from the `main` branch on the Tuesday after | |||
There was a problem hiding this comment.
I'm thinking to change the Instrumentation release date to the Thursday after this
| val DEPENDENCY_BOMS = listOf( | ||
| "com.fasterxml.jackson:jackson-bom:2.18.2", | ||
| "com.google.guava:guava-bom:33.3.1-jre", | ||
| "com.linecorp.armeria:armeria-bom:1.31.2", | ||
| "org.junit:junit-bom:5.11.3", | ||
| "io.grpc:grpc-bom:1.68.2", | ||
| "io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha:${otelInstrumentationVersion}", | ||
| "io.opentelemetry:opentelemetry-bom-alpha:1.44.1-alpha", |
There was a problem hiding this comment.
I didn't update to 1.45.0 in order to ensure everything works smoothly when renovate updates it after this PR is merged
| @@ -22,7 +22,7 @@ dependencies { | |||
| runtimeOnly("io.opentelemetry:opentelemetry-exporter-otlp") | |||
| runtimeOnly("io.opentelemetry:opentelemetry-exporter-logging") | |||
|
|
|||
| implementation("io.opentelemetry.instrumentation:opentelemetry-jmx-metrics") | |||
| implementation("io.opentelemetry.instrumentation:opentelemetry-jmx-metrics:2.10.0-alpha") | |||
There was a problem hiding this comment.
Moving contrib before instrumentation in the release allows to remove this circular dependency if we move the JMX insights code directly into contrib and then reuse it as-is in instrumentation. Do you think this would be something relevant to do ? It also changes a bit the "ownership" of the JMX-related code in the instrumentation by relying on the component owners of contrib instead.
There was a problem hiding this comment.
I think I'd prefer to go in the other direction and keep / move things that we release as part of the core java agent distribution into the java instrumentation repo (@laurit wdyt? EDIT: we could introduce "component owners" in that repo similar to this repo)
@jackshirazi would this address your concern about release ordering, and we could go back to releasing instrumentation repo first and then contrib repo?
There was a problem hiding this comment.
If I understand that means:
- moving contrib components that are included in instrumentation to instrumentation (with same component owners), for example: cloud resource attribute providers, aws x-ray propagator and baggage processor
- removing any dependency from instrumentation to contrib
- contrib can still depend on instrumentation and/or SDK, for example like the jmx-scraper reusing the
instrumentation/jmx-metricscomponent.
One interesting aspect of adding component owners directly in instrumentation is that it helps to delegate changes that are related to those components to their respective owners.
There was a problem hiding this comment.
@jackshirazi would this address your concern about release ordering, and we could go back to releasing instrumentation repo first and then contrib repo?
The concern is that if any contrib project needs a fix, it's an extra month before the agent gets that fix (if we release agent before contrib). It's not a dramatically bad concern, and it hasn't been an actual issue so far.
…telemetry#1581)" This reverts commit 2b46b8c.
cc @jackshirazi