span stacktrace refactor + autoconfig #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
reviewed
Oct 16, 2024
span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceAutoConfig.java
Outdated
Show resolved
Hide resolved
span-stacktrace/src/test/java/io/opentelemetry/contrib/stacktrace/StackTraceAutoConfigTest.java
Show resolved
Hide resolved
trask
reviewed
Oct 16, 2024
JonasKunz
approved these changes
Oct 17, 2024
trask
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK version 1.42.0 introduced with (#6367) a new
ExtendedSpanProcessor.onEnding(ReadWriteSpan span)that provide a hook to modify the span on end, which theSpanProcessor.onEnd(ReadableSpan readableSpan)does not allow.This allows to simplify the current implementation of span stacktrace capture by removing all internal classes. This also allows to implement autoconfiguration which is also part of this PR.
When using autoconfiguration, this PR introduces the
otel.java.experimental.span-stacktrace.filterconfiguration option which allows to provide the class name of the filter.This is a breaking change and users of this module will see a compile-time error due to the change in the
StackTraceSpanProcessorconstructor arguments.