Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-collector] Remove default resource values #745

Merged
merged 1 commit into from
Apr 18, 2023
Merged

[opentelemetry-collector] Remove default resource values #745

merged 1 commit into from
Apr 18, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Apr 16, 2023 •
edited
Loading

Pushing this forward since #645 went stale :)

This time using fork 😓

Closes #644

Updating patch version and added note in Upgrading doc and Notes.txt :)

@povilasv povilasv mentioned this pull request Apr 16, 2023
Closed
@povilasv povilasv marked this pull request as ready for review April 16, 2023 15:37
@povilasv povilasv requested a review from a team April 16, 2023 15:37
@povilasv povilasv force-pushed the collector-remove-resource-values6 branch 2 times, most recently from 75e44d5 to cb56a9f Compare April 17, 2023 19:55
@povilasv povilasv requested a review from TylerHelmuth April 17, 2023 19:55
@povilasv povilasv force-pushed the collector-remove-resource-values6 branch from cb56a9f to ead1e5f Compare April 17, 2023 19:56
@povilasv povilasv force-pushed the collector-remove-resource-values6 branch from ead1e5f to fbd8e94 Compare April 18, 2023 17:48
@povilasv povilasv requested a review from TylerHelmuth April 18, 2023 17:53
TylerHelmuth
TylerHelmuth approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitryax please review.

dmitryax
dmitryax approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerHelmuth TylerHelmuth reopened this Apr 18, 2023
@TylerHelmuth TylerHelmuth merged commit b51690d into open-telemetry:main Apr 18, 2023
@povilasv povilasv deleted the collector-remove-resource-values6 branch April 19, 2023 05:09
@sleterrier sleterrier mentioned this pull request Aug 5, 2023
Closed
@TylerHelmuth TylerHelmuth mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[collector] Unable to remove CPU limits when used as a subchart
3 participants
@povilasv @dmitryax @TylerHelmuth