feat(opentelemetry-collector): use Kubernetes recommended label for c… #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
|
I guess this is breaking change 🤔 People could have used component=agent-collector in other resources like Ingress / Network policies / ... So maybe we should stick with old label? |
|
I agree this is a breaking change. We can add a new label but should leave the existing one for now. |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/ping |
|
@nlamirault please bump the patch version of the chart and run |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
jaronoff97
approved these changes
Nov 22, 2024
|
(once this is updated with the latest and examples are generated, should be good) |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
TylerHelmuth
approved these changes
Nov 25, 2024
|
This is still a breaking change and shouldn't be a patch release. It changes Deployment's |
|
@z0rc thanks, I'll submit a pr to fix this. |
rohanarora
pushed a commit
to rohanarora/opentelemetry-helm-charts
that referenced
this pull request
Dec 2, 2024
open-telemetry#1396) * feat(opentelemetry-collector): use Kubernetes recommended label for component Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): use also previous label Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): chart version Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): generate examples Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): generate examples Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): generate examples Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): generate examples Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): cleanup Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> * feat(helm): generate examples Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com> --------- Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Kubernetes commended labels for
componentlabel.