[operator] allow setting custom recommender name #1223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t3mi <t3mi@users.noreply.github.com>
jaronoff97
reviewed
Jun 21, 2024
| "additionalProperties": false | ||
| }, | ||
| "examples": [ | ||
| [] |
There was a problem hiding this comment.
can you add an example for this?
Comment on lines
+144
to
+148
| # Recommender responsible for generating recommendation for the object. | ||
| # List should be empty (then the default recommender will generate the recommendation) | ||
| # or contain exactly one recommender. | ||
| # recommenders: | ||
| # - name: custom-recommender-performance |
There was a problem hiding this comment.
Given the VPA's recommenders list can only have a single item does it make sense for us to expose this field as a list instead of just a string to set? i.e. if len(recommender.name) > 0 set it, otherwise don't?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for multiple recommenders with different configurations to be present in single cluster. This change allows VPA configuration to be updated by custom recommender if one was set, otherwise - default recommender is used.