Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic convention for faas.coldstart and container.id #909

Merged
merged 3 commits into from
Jul 7, 2020
Merged

Add semantic convention for faas.coldstart and container.id #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8abe0ff
Add semantic convention for faas coldstart and container ID
matej-g Jul 6, 2020
ef3fa59
Update Changelog
matej-g Jul 6, 2020
1792c67
Merge branch 'master' into semantic-convention-faas-coldstart-contain…
MrAlias Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
### Added

- Add `peer.service` semantic attribute. (#898)
- Add semantic convention for `faas.coldstart` and `container.id`. (#909)

### Changed

Expand Down
4 changes: 4 additions & 0 deletions api/standard/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ const (
// A uniquely identifying name for the Container.
ContainerNameKey = kv.Key("container.name")

// Container ID, usually a UUID, as for example used to
// identify Docker containers. The UUID might be abbreviated.
ContainerIDKey = kv.Key("container.id")

// Name of the image the container was built on.
ContainerImageNameKey = kv.Key("container.image.name")

Expand Down
4 changes: 4 additions & 0 deletions api/standard/trace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ const (
// String containing the execution identifier of the function.
FaaSExecutionKey = kv.Key("faas.execution")

// A boolean indicating that the serverless function is executed
// for the first time (aka cold start).
FaaSColdstartKey = kv.Key("faas.coldstart")

// The name of the source on which the operation was performed.
// For example, in Cloud Storage or S3 corresponds to the bucket name,
// and in Cosmos DB to the database name.
Expand Down