Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix go-work Make target with the highest required Go version #6285

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

pellared
Copy link
Member

@pellared pellared commented Feb 7, 2025

This is handy for gopls when working across multiple Go modules.
Currently crosslink work has a default value of 1.22 for go flag which does not work for the current codebase.
The go 1.22.7 version is required in go.opentelemetry.io/otel/bridge/opentracing/test.

@pellared pellared changed the title [chore] Update go-work Make target with the highest required Go version [chore] Fix go-work Make target with the highest required Go version Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (d9ab149) to head (0d57e6e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6285   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files        283     283           
  Lines      24892   24892           
=====================================
+ Hits       20379   20380    +1     
+ Misses      4109    4108    -1     
  Partials     404     404           

see 2 files with indirect coverage changes

@pellared pellared requested a review from dmathieu February 10, 2025 14:30
@MrAlias MrAlias merged commit 9d4c2f7 into open-telemetry:main Feb 13, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants