-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dice example #4539
Merged
Merged
Add dice example #4539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
September 21, 2023 12:12
dmathieu
reviewed
Sep 21, 2023
svrnm
approved these changes
Sep 21, 2023
nice work @pellared |
MrAlias
reviewed
Sep 21, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dmathieu
approved these changes
Sep 22, 2023
cartermp
approved these changes
Sep 22, 2023
Co-authored-by: Phillip Carter <pcarter@fastmail.com>
93a69bc is addressing comments from open-telemetry/opentelemetry.io#3310 (review) |
@dashpole Can you please take a quick look as I think you already reviewed this code? 😉 |
dashpole
approved these changes
Sep 26, 2023
MrAlias
approved these changes
Sep 26, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4531
Mostly based on https://opentelemetry.io/docs/instrumentation/python/getting-started/ (but also looked at other languages)
Remarks
I did my best to make the example reasonably close to “real production code” (however, without tests).
I started with
But I needed graceful shutdown (via SIGINT) to properly handle cleanup. Second SIGINT should kill the application.
I also decided to restructure the code and e.g. avoid using globals.
Moreover, I set server's WriteTimeout and ReadTimeout as it is a good practice.