-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move global metric back to otel/metric/global
for minor release
#3986
Merged
MrAlias
merged 6 commits into
open-telemetry:main
from
MrAlias:remove-otel-global-metric
Apr 13, 2023
Merged
Move global metric back to otel/metric/global
for minor release
#3986
MrAlias
merged 6 commits into
open-telemetry:main
from
MrAlias:remove-otel-global-metric
Apr 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pen-telemetry#3818)" This reverts commit 8139361.
625577e
to
38213f7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
=======================================
- Coverage 82.1% 82.1% -0.1%
=======================================
Files 174 175 +1
Lines 12975 12975
=======================================
- Hits 10655 10653 -2
- Misses 2100 2102 +2
Partials 220 220
|
38213f7
to
69830fb
Compare
pellared
approved these changes
Apr 11, 2023
MadVikingGod
approved these changes
Apr 12, 2023
This was referenced Apr 27, 2023
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Apr 28, 2023
…ease (open-telemetry#3986)" This reverts commit 8dba38e.
MrAlias
added a commit
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the major changes we plan to release (#3973, #3971), it was decided at last week's SIG meeting that we will release them as another minor release and then go back into a stability RC cycle. This reverts the move of having the unstable metric API added to the stable global API.