Upgrades dependencies #3346
Closed
Upgrades dependencies #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the dependabot PRs were handled via #3348. Would be interested to see the result of this approach after that. I think it's just the transitive dependencies and those using pseudoversions. |
|
I will redo this on the new main and see. |
|
@MadVikingGod Can you run |
pellared
approved these changes
Oct 17, 2022
|
I think I see two categories of change here:
Definitely good with 1) but I'm not sure we need to/should do 2). What are the risks and rewards of updating our transitive dependencies before they're updated where they are direct dependencies? |
|
Should this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done by using
go get -u -t ./...for all directories with a go mod. This will upgrade transitive dependencies, and if any were pinned.This would supersede #3294 - #3338resolved elsewhere.