-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in example/fib/app.go line:69 #2860
Fix a bug in example/fib/app.go line:69 #2860
Conversation
…id process break by "unexpected newline"
See #2644. |
ok, I have modified the "getting-started.md" file, which refers to #2644. |
Codecov Report
@@ Coverage Diff @@
## main #2860 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 180 180
Lines 11818 11818
=====================================
+ Hits 8949 8951 +2
+ Misses 2636 2634 -2
Partials 233 233
|
After testing this bug does affect windows powershell, see #2862. I believe that this change will fix powershell and not adversely affect any other platform. If someone has the chance to test with a mac I would appreciate it. |
I would also like to point out that the reason this PR should be considered while the first two PRs weren't is this description has enough information to reproduce. We welcome both bug reports and PRs, but we need to know why a change should be made. If you start with a bug report before or at the same time as a PR then we can get the reasoning behind the change. |
@MadVikingGod are you able to verify this PR resolves #2862? I have verified this does not change the working behavior on a Linux system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this does fix the powershell, and it doesn't affect mac or windows linuxs
Fixes #2862
dev env:
Describe:
when I run the example of fib,the loop will be Breaked by the Fscanf().
the error message:
Fix method:
append a "\n" to the param string in Fscanf().