use LinkedTo rather than ChildOf for PublicEndpoint #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freeformz @freeformzSFDC @iredelmeier FYI, and thank you <3 |
jmacd
approved these changes
Nov 1, 2019
| opt = trace.ChildOf(sc) | ||
| // If the endpoint is a public endpoint, it should start a new trace | ||
| // and incoming remote sctx should be added as a link. | ||
| opt = trace.LinkedTo(sc) | ||
| } else { // not a private endpoint, so assume child relationship | ||
| opt = trace.ChildOf(sc) |
There was a problem hiding this comment.
On this note, aren't we removing ChildOf? I'm on the fence about this, because we still haven't fully clarified SpanKind. open-telemetry/opentelemetry-specification#337
There was a problem hiding this comment.
In either case we need a way to set the parent relationship, regardless of whether it's precisely specified according to SpanKind or more generic.
I am fine with punting this until we more fully remove ChildOf and just updating in place when we do so.
krnowak
approved these changes
Nov 1, 2019
bogdandrutu
approved these changes
Nov 4, 2019
|
Exigency: need this code in the repo for OTel workshop tomorrow to behave correctly. It has a maintainer and approver stamp on it, so using governance powers to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes us to no longer emit missing root spans if we do not have the trace associated with the tracing headers we receive on public endpoints.