Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use randomly-available port in otlp exporters tests #2627

Merged
merged 7 commits into from
Feb 22, 2022
Merged

Use randomly-available port in otlp exporters tests #2627

merged 7 commits into from
Feb 22, 2022

Conversation

dmathieu
Copy link
Member

These tests are randomly failing quite frequently (See https://github.com/open-telemetry/opentelemetry-go/runs/5252854681 for example).
As far as I can see, the TCP listener is always closed properly. So I'm assuming this may be due to tests running in parallel (maybe across runs?).

By using random ports, we guarantee we will always have a free port, which should remove the test flakiness.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #2627 (2ba3c7d) into main (8ba8f68) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2627   +/-   ##
=====================================
  Coverage   76.1%   76.1%           
=====================================
  Files        173     173           
  Lines      12234   12234           
=====================================
+ Hits        9318    9322    +4     
+ Misses      2673    2669    -4     
  Partials     243     243           
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 21, 2022
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dmathieu and others added 5 commits February 22, 2022 22:17
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@Aneurysm9 Aneurysm9 merged commit d51d1b3 into open-telemetry:main Feb 22, 2022
@dmathieu dmathieu deleted the random-port branch February 23, 2022 08:30
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants