Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the website getting started docs #2203

Merged
merged 13 commits into from
Sep 2, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 27, 2021

Add a new example, fib, that contains an application for the computation of Fibonacci numbers. Use this example to update the website getting started documentation.

Resolves #2117

@MrAlias MrAlias added the documentation Provides helpful information label Aug 27, 2021
Add a new example, fib, that contains an application for the computation
of Fibonacci numbers. Use this example to update the website getting
started documentation.
@MrAlias MrAlias force-pushed the getting-started-docs branch from c3949b2 to cd084b8 Compare August 27, 2021 00:40
@MrAlias MrAlias marked this pull request as ready for review August 27, 2021 00:44
@MrAlias MrAlias marked this pull request as draft August 27, 2021 15:09
@MrAlias MrAlias force-pushed the getting-started-docs branch 2 times, most recently from 57e6b1c to 8f2ee31 Compare August 27, 2021 16:42
MrAlias and others added 2 commits August 27, 2021 09:47
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@MrAlias MrAlias force-pushed the getting-started-docs branch from 8f2ee31 to 1a71cc5 Compare August 27, 2021 16:48
@MrAlias MrAlias marked this pull request as ready for review August 27, 2021 17:23
MrAlias and others added 2 commits August 27, 2021 11:07
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor suggestion re: error handling

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #2203 (ff820f5) into main (a7b9d02) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2203   +/-   ##
=====================================
  Coverage   72.8%   72.9%           
=====================================
  Files        176     176           
  Lines      12162   12162           
=====================================
+ Hits        8866    8868    +2     
+ Misses      3057    3055    -2     
  Partials     239     239           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 94.3% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit 04de34a into open-telemetry:main Sep 2, 2021
@MrAlias MrAlias deleted the getting-started-docs branch September 2, 2021 15:22
Comment on lines +83 to +84
sigCh := make(chan os.Signal, 1)
signal.Notify(sigCh, os.Interrupt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the signal.NotifyContext function instead.

@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove package import alias requirement
7 participants