-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the website getting started docs #2203
Conversation
Add a new example, fib, that contains an application for the computation of Fibonacci numbers. Use this example to update the website getting started documentation.
c3949b2
to
cd084b8
Compare
57e6b1c
to
8f2ee31
Compare
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
8f2ee31
to
1a71cc5
Compare
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor suggestion re: error handling
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #2203 +/- ##
=====================================
Coverage 72.8% 72.9%
=====================================
Files 176 176
Lines 12162 12162
=====================================
+ Hits 8866 8868 +2
+ Misses 3057 3055 -2
Partials 239 239
|
sigCh := make(chan os.Signal, 1) | ||
signal.Notify(sigCh, os.Interrupt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using the signal.NotifyContext
function instead.
Add a new example, fib, that contains an application for the computation of Fibonacci numbers. Use this example to update the website getting started documentation.
Resolves #2117