Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(exporter/zipkin): improves logging on invalid collector. #2191

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

jcchavezs
Copy link
Contributor

@jcchavezs jcchavezs commented Aug 18, 2021

ATM logs for invalid collector URL are kind of helpless. This PR improves the logs to be actionable.

Ping @bogdandrutu

@MrAlias
Copy link
Contributor

MrAlias commented Aug 18, 2021

It looks like tests need to be updated to match these changes.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #2191 (5ec479c) into main (c0c5ef6) will decrease coverage by 0.0%.
The diff coverage is 50.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2191     +/-   ##
=======================================
- Coverage   72.9%   72.9%   -0.1%     
=======================================
  Files        176     176             
  Lines      12161   12161             
=======================================
- Hits        8870    8867      -3     
- Misses      3053    3055      +2     
- Partials     238     239      +1     
Impacted Files Coverage Δ
exporters/zipkin/zipkin.go 69.7% <50.0%> (ø)
...s/otlp/otlptrace/internal/connection/connection.go 14.8% <0.0%> (-1.6%) ⬇️

@jcchavezs
Copy link
Contributor Author

Done @MrAlias

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 19, 2021
@Aneurysm9 Aneurysm9 merged commit e209ee7 into open-telemetry:main Aug 30, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants