-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize API into Go modules based on stability and dependencies #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punya
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
February 11, 2021 16:45
punya
force-pushed
the
migrate-metric-funcs
branch
from
February 11, 2021 17:00
b542bbe
to
420e00a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1528 +/- ##
=======================================
- Coverage 79.0% 77.7% -1.3%
=======================================
Files 127 127
Lines 6683 6683
=======================================
- Hits 5280 5195 -85
- Misses 1148 1244 +96
+ Partials 255 244 -11
|
Aneurysm9
reviewed
Feb 11, 2021
This was referenced Feb 11, 2021
punya
changed the title
Move metric-related public API out of otel/ pkg
Organize API into Go modules based on stability and dependencies
Feb 11, 2021
* otel/metric * otel/trace * otel/oteltest * otel/sdk/export/metric * otel/sdk/metric Relates to open-telemetry#1467
Move GetMeterProvider, Meter and SetMeterProvider to new package otel/metric/global in the otel/metric module. This will allow otel/ module to be released as v1.0.
punya
force-pushed
the
migrate-metric-funcs
branch
from
February 11, 2021 19:18
420e00a
to
de91005
Compare
MrAlias
reviewed
Feb 11, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Feb 11, 2021
MrAlias
reviewed
Feb 11, 2021
punya
force-pushed
the
migrate-metric-funcs
branch
from
February 12, 2021 04:58
45e0bcb
to
3da34ae
Compare
XSAM
approved these changes
Feb 12, 2021
Merged
ldelossa
pushed a commit
to ldelossa/opentelemetry-go
that referenced
this pull request
Mar 5, 2021
…n-telemetry#1528) * Add a tool to auto-generate replace directives * Auto-generated changes from previous commit * Create new modules required for trace release * otel/metric * otel/trace * otel/oteltest * otel/sdk/export/metric * otel/sdk/metric Relates to open-telemetry#1467 * Move metric-related public API out of otel/ pkg Move GetMeterProvider, Meter and SetMeterProvider to new package otel/metric/global in the otel/metric module. This will allow otel/ module to be released as v1.0. * Include PR references in CHANGELOG Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Check for root dir Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1467.
This PR
Future work
Reviewers: I recommend looking at this commit-by-commit instead of as a combined diff.