Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update otel-collector example #1006

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

stefanprisca
Copy link
Contributor

Addressing issue #991

There were two main issues with the example:

  1. It was using an old name for the jaeger exporter (see 760)
  • Solution: changed_ the exporter name to "jaeger"
  1. The otel collector expects tls connections to exporters by default (see 1191)
  • Solution: added the "insecure: true" setting to the jaeger exporter.

Additional changes:

  • Since the commonLabels attributes were being used for metrics, I thought it might be nice to use them in the traces as well, to show this use-case also.
  • Bumped the collector version to latest verified version 0.6.0

@MrAlias MrAlias merged commit fc1ce6c into open-telemetry:master Jul 31, 2020
@Aneurysm9 Aneurysm9 mentioned this pull request Aug 24, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants