config: separate schema version support into separate directories #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the migration from one version to another explicit in any downstream dependencies. This will make dealing with breaking changes much easier in the Collector as it will allow us to have end users toggle a feature gate to enable support for new schema versions. Doing this today is not possible as we cannot import both a v0.2.0 and a v0.3.0 compatible config package. With the change in this PR, this will be possible. v0.2.0 directory was a copy based on 355fbbd Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
=======================================
+ Coverage 67.0% 67.7% +0.7%
=======================================
Files 193 199 +6
Lines 15660 16564 +904
=======================================
+ Hits 10497 11229 +732
- Misses 4874 4993 +119
- Partials 289 342 +53
|
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
MrAlias
reviewed
Dec 9, 2024
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
|
test fixed 👍🏻 |
dmathieu
approved these changes
Dec 10, 2024
Co-authored-by: Damien Mathieu <42@dmathieu.com>
MrAlias
approved these changes
Dec 10, 2024
MrAlias
added a commit
that referenced
this pull request
Dec 12, 2024
### Added - Added support for providing `endpoint`, `pollingIntervalMs` and `initialSamplingRate` using environment variable `OTEL_TRACES_SAMPLER_ARG` in `go.opentelemetry.io/contrib/samples/jaegerremote`. (#6310) - Added support exporting logs via OTLP over gRPC in `go.opentelemetry.io/contrib/config`. (#6340) - The `go.opentelemetry.io/contrib/bridges/otellogr` module. This module provides an OpenTelemetry logging bridge for `github.com/go-logr/logr`. (#6386) - Added SNS instrumentation in `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`. (#6388) ### Changed - Change the span name to be `GET /path` so it complies with the OTel HTTP semantic conventions in `go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho`. (#6365) - Record errors instead of setting the `gin.errors` attribute in `go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`. (#6346) - The `go.opentelemetry.io/contrib/config` now supports multiple schemas in subdirectories (i.e. `go.opentelemetry.io/contrib/config/v0.3.0`) for easier migration. (#6412) ### Fixed - Fix broken AWS presigned URLs when using instrumentation in `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`. (#5975) - Fixed the value for configuring the OTLP exporter to use `grpc` instead of `grpc/protobuf` in `go.opentelemetry.io/contrib/config`. (#6338) - Allow marshaling types in `go.opentelemetry.io/contrib/config`. (#6347) - Removed the redundant handling of panic from the `HTML` function in `go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`. (#6373) - The `code.function` attribute emitted by `go.opentelemetry.io/contrib/bridges/otelslog` now stores just the function name instead the package path-qualified function name. The `code.namespace` attribute now stores the package path. (#6415) - The `code.function` attribute emitted by `go.opentelemetry.io/contrib/bridges/otelzap` now stores just the function name instead the package path-qualified function name. The `code.namespace` attribute now stores the package path. (#6423)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the migration from one version to another explicit in any downstream dependencies. This will make dealing with breaking changes much easier in the Collector as it will allow us to have end users toggle a feature gate to enable support for new schema versions.
Doing this today is not possible as we cannot import both a v0.2.0 and a v0.3.0 compatible config package. With the change in this PR, this will be possible.
v0.2.0 directory was a copy based on 355fbbd