Split dice example into instrumented and uninstrumented

[IgorEulalio]

As discussed in this thread, we want to have two different examples, one with instrumentation and one without it.

Fixes #6296

[pellared]

Please fix the build.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (b3ccbc6) to head (7b3a1af).
Report is 1 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #6300   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        193     193           
  Lines      15660   15660           
=====================================
  Hits       10494   10494           
  Misses      4876    4876           
  Partials     290     290           

[IgorEulalio]

@pellared ran locally and linter is now working.

[IgorEulalio]

@pellared uninstrumented didn't have the no-go lint for the rand.Int function, just added it.

[pellared]

Please also update .gitignore.

[IgorEulalio]

done

[IgorEulalio]

@pellared conflict here's due I removed go.mod file from examples directly while origin modified it, is there anything I need to do here?

[IgorEulalio]

I merged the remote branch of the core repo into my fork

[pellared]

@open-telemetry/docs-maintainers, is it something you want to help with maintaining https://github.com/open-telemetry/opentelemetry.io/blob/main/content/en/docs/languages/go/getting-started.md?

[svrnm]

thanks for working on this @IgorEulalio, I will provide a review as soon as I can.

Note, that I recently proposed a project which is related to your work here, feel free to take a look and let me know if you'd like to participate: open-telemetry/community#2427

[IgorEulalio]

@svrnm I took a look at the community issue, I would love to help and participate in this project. Do we already have something started on that?

[svrnm]

@svrnm I took a look at the community issue, I would love to help and participate in this project. Do we already have something started on that?

No, nothing has started yet, I am currently seeing to find people who are interested in helping. So if you comment on that PR that you are interested in helping and in which capacity then I can add you to the Staffing

[svrnm]

lgtm overall, thanks for taking the time to make this! A few inline comments to align it better with what we need for the website

[chalin]

Related:

• Go getting-started code: reinstate code-excerpting opentelemetry.io#5631

[svrnm]

lgtm now (minus the conflicts that need to be resolved)

[pellared]

Build is failing

[IgorEulalio]

@pellared @svrnm I fixed the linter issue by removing the lint as it didn't make sense for me to the perfect appointment.

Let me know if you prefer to fix it trough code refactor.

[pellared]

I fixed the linter issue by removing the lint as it didn't make sense for me to the perfect appointment.

Let me know if you prefer to fix it trough code refactor.

I find it bad that the uninstrumented and instrumented code for this line does not match:

opentelemetry-go-contrib/examples/dice/instrumented/rolldice.go

Line 45 in 76e0578

msg = player + " is rolling the dice"

and

opentelemetry-go-contrib/examples/dice/uninstrumented/rolldice.go

Line 20 in 76e0578

msg = fmt.Sprintf("%s is rolling the dice", player) //nolint:perfsprint

I prefer the version without nolint (which is currently in main, I see no reason to change it).

[IgorEulalio]

@pellared done

[pellared]

@pellared done

This #6300 (comment) is not resolved.

[IgorEulalio]

This #6300 (comment) is not resolved.

Completely missed that one, it's fixed now.

[pellared]

@svrnm, @chalin, can you please double-check?

[IgorEulalio]

Hi folks, just checking if there's anything missing from my side here, thanks!

[pellared]

@open-telemetry/go-maintainers, planning to merge in ~24h, last chance to review.

[pellared]

@IgorEulalio, thank you for your contribution and your patience 🏅

[svrnm]

🎉 Thanks @IgorEulalio

[IgorEulalio]

Thank you guys for the patience and help, looking forward to contribute more with this amazing project.