Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: enable compares and negative-positive rules from testifylint #6139

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mmorel-35
Copy link
Contributor

Description

Testifylint is a linter that provides best practices with the use of testify.

This PR enables compares and negative-positive rules from testifylint

@mmorel-35 mmorel-35 requested review from pellared, a team and MadVikingGod as code owners September 22, 2024 19:59
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about to ask the compares, but it is ok now. 😄

@mmorel-35
Copy link
Contributor Author

There was a merge from the main branch. I fixed it with a rebase

@pellared pellared merged commit d9fab90 into open-telemetry:main Sep 24, 2024
25 checks passed
@mmorel-35 mmorel-35 deleted the testifylint/compares branch September 24, 2024 18:10
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
@renovate renovate bot mentioned this pull request Nov 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants