Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use testing.T.Setenv in aws:ecs #4618

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Refactor to use testing.T.Setenv in aws:ecs #4618

merged 1 commit into from
Nov 27, 2023

Conversation

takp
Copy link
Contributor

@takp takp commented Nov 25, 2023 •
edited
Loading

Closes #4616.

During this refactoring, I also find the other modules are also using os.Setenv for testing. Maybe we can update them by just doing the same.

@takp takp requested a review from Aneurysm9 as a code owner November 25, 2023 04:57
@takp takp requested a review from a team November 25, 2023 04:57
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Nov 25, 2023
@pellared
Copy link
Member

Maybe we can update them by just doing the same.

Go for it 👍 We appreciate your contributions.

@pellared pellared merged commit d50aa19 into open-telemetry:main Nov 27, 2023
22 of 23 checks passed
@takp takp mentioned this pull request Nov 28, 2023
Merged
@takp takp deleted the refactor-to-use-testing.T.Setenv branch November 29, 2023 13:28
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees
No one assigned
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

detectors: aws:ecs: Refactor to use testing.T.Setenv
3 participants
@takp @pellared @dmathieu