-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(otelgrpc): correctly assign grpc status code #4481
fix(otelgrpc): correctly assign grpc status code #4481
Conversation
a58a6de
to
73fa3a6
Compare
Codecov Report
@@ Coverage Diff @@
## main #4481 +/- ##
=====================================
Coverage 80.8% 80.8%
=====================================
Files 150 150
Lines 10245 10245
=====================================
Hits 8284 8284
Misses 1823 1823
Partials 138 138
|
7660db2
to
4184777
Compare
4184777
to
f902f4d
Compare
@dashpole Thanks for the fast review. I pushed in again to fix some formatting issues. |
I think the failed test is related to #4416? |
instrumentation/google.golang.org/grpc/otelgrpc/test/interceptor_test.go
Show resolved
Hide resolved
90% that you are correct. I just left 2 minor comments that I would love to have addressed and one bigger for which I created a separate issue. Thanks for your contribution 👍 |
Thanks, I fixed up the 2 minor comments as you suggested :) |
closes #4480
I tried to write a test as well to capture the issue above, also made a fix in
interceptor.go