Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Add metrics support to NewServerHandler and NewClientHandler #4356

Merged
merged 10 commits into from
Nov 6, 2023

Merge branch 'main' into otelgrpc-statshandler-support-metric

da2f358
Select commit
Loading
Failed to load commit list.
Merged

otelgrpc: Add metrics support to NewServerHandler and NewClientHandler #4356

Merge branch 'main' into otelgrpc-statshandler-support-metric
da2f358
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 6, 2023 in 0s

70.9% of diff hit (target 80.9%)

View this Pull Request on Codecov

70.9% of diff hit (target 80.9%)

Annotations

Check warning on line 99 in instrumentation/google.golang.org/grpc/otelgrpc/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/config.go#L98-L99 

Added lines #L98 - L99 were not covered by tests

Check warning on line 106 in instrumentation/google.golang.org/grpc/otelgrpc/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/config.go#L105-L106 

Added lines #L105 - L106 were not covered by tests

Check warning on line 113 in instrumentation/google.golang.org/grpc/otelgrpc/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/config.go#L112-L113 

Added lines #L112 - L113 were not covered by tests

Check warning on line 120 in instrumentation/google.golang.org/grpc/otelgrpc/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/config.go#L119-L120 

Added lines #L119 - L120 were not covered by tests

Check warning on line 59 in instrumentation/google.golang.org/grpc/otelgrpc/metadata_supplier.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/metadata_supplier.go#L59 

Added line #L59 was not covered by tests

Check warning on line 81 in instrumentation/google.golang.org/grpc/otelgrpc/metadata_supplier.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/metadata_supplier.go#L81 

Added line #L81 was not covered by tests

Check warning on line 185 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L185 

Added line #L185 was not covered by tests

Check warning on line 204 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L204 

Added line #L204 was not covered by tests

Check warning on line 214 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L213-L214 

Added lines #L213 - L214 were not covered by tests

Check warning on line 218 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L217-L218 

Added lines #L217 - L218 were not covered by tests

Check warning on line 226 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L225-L226 

Added lines #L225 - L226 were not covered by tests

Check warning on line 230 in instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

instrumentation/google.golang.org/grpc/otelgrpc/stats_handler.go#L229-L230 

Added lines #L229 - L230 were not covered by tests
View more details on Codecov