[Cortex] Add support for histogram and distribution #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Aug 18, 2020
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…/opentelemetry-go-contrib into finish-convert-metrics
…try-go-contrib into finish-convert-metrics
…/opentelemetry-go-contrib into finish-convert-metrics
MrAlias
approved these changes
Aug 18, 2020
|
for future, please prefix name of component in [] in PR description. |
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Jaeger exporter should be its own go module open-telemetry/opentelemetry-go#205 * fix review comments and build #205 * resolve mod conflicts #205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for histogram and distribution aggregations in the Cortex Exporter by adding functionality in
cortex.go. I also refactored tests incortex_test.go. To support buckets and quantiles, I also added two fields toconfig.go.There are a few other minor changes like adding a link to Viper in the README, switching to a
NewWithHistogramDistributionProcessor, and modifying the conversion logic (control flow to select which aggregation needs to be converted).