otelmux: fix: Do not require calling Write nor WriteHeader #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1443 +/- ##
=====================================
Coverage 69.2% 69.3%
=====================================
Files 127 127
Lines 5475 5474 -1
=====================================
Hits 3794 3794
+ Misses 1534 1533 -1
Partials 147 147
|
Aneurysm9
approved these changes
Nov 24, 2021
MrAlias
approved these changes
Nov 24, 2021
instrumentation/github.com/gorilla/mux/otelmux/test/mux_test.go
Outdated
Show resolved
Hide resolved
XSAM
approved these changes
Nov 26, 2021
rltoSD
referenced
this pull request
in open-o11y/opentelemetry-go-contrib
Dec 21, 2021
* Change tests to make it failing * Fix otelmux to not require calling Write nor WriteHeader * Update changelog * Fix changelog * Fix * Refactor
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
…sor (#1443) * Fix BatchSpanProcessor does not shutdown underlying span exporter * Update CHANGELOG * Fix tests * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1387
go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmuxdoes not require the instrumented HTTP handlers to callWritenorWriteHeaderanymore