Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for github.com/graph-gophers/graphql-go #85

Closed
4 tasks
MrAlias opened this issue Jun 18, 2020 · 5 comments
Closed
4 tasks

Add instrumentation for github.com/graph-gophers/graphql-go #85

MrAlias opened this issue Jun 18, 2020 · 5 comments
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jun 18, 2020

https://github.com/graph-gophers/graphql-go

Tasks

  • code complete with tests passing
  • Dockerfile with example app showing instrumentation
  • documentation updated
  • instrumentation added to the opentelemetry registry

Prior Art

@MrAlias MrAlias added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed area: instrumentation Related to an instrumentation package labels Jun 18, 2020
@gtourkas
Copy link

@MrAlias may I pick this up ?

@pellared
Copy link
Member

pellared commented Sep 6, 2021

@ravilushqa @jay-manday @jjmengze @gtourkas
Could you please try to collaborate and select one of your PRs as a preferred one (and make other PRs as a draft) to make the reviewers' life easier? 😉

@ravilushqa
Copy link

ravilushqa commented Sep 6, 2021

@pellared
This issue how i see opened for graph-gophers/graphql-go lib, whereas mine and @jjmengze is for 99designs/gqlgen. I'm not sure that both lib should go in a one MR, and imo that would be harder for reviewers.

In situation with @jjmengze, our pr's are both for a one lib. I'm not experienced contributor, so i'm not pretty sure how to deal with that. I'm pretty long waiting for it, and I will be happy if we will collaborate around it.

My suggest is to contribute separately this one, and mine #761 :)

@gtourkas
Copy link

gtourkas commented Sep 6, 2021

@pellared

@ravilushqa sufficiently described the case: this PR for for graph-gophers/graphql-go, which is also what the issue #85 is about, and the other two for 99designs/gqlgen . Apart from the registry item, which I guess is the last step, the PR is imo ready for review.

@MrAlias
Copy link
Contributor Author

MrAlias commented Oct 14, 2021

In accordance with the new instrumentation policy hosting guidelines I'm closing this.

@MrAlias MrAlias closed this as completed Oct 14, 2021
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* add propagation api.

* add http propagator interface and w3c propagator implementation.

* remove Extract api from trace.

* remove Extract interface for tracer.

* fix copyright.

* fix variable names and comments.

* move inject/extract out of trace.

* replace INVALID_SPAN_CONTEXT with EmptySpanContext function.

* fix tag.Map.

* make carrier as interface instead of http.Request.

* rename structs and update doc comments..

* add doc.go

* update doc.

* add noop propagator.

* add new propagation api with Supplier interface.
- added Default Tracer which simply propagates SpanContext.
- added CopyOfRemote option to simply create remote span.

* remove old propagator.

* rename propagator to TextFormatPropagator.

* rename default tracer/span as pass_through tracer/span.

* add test for pass through tracer.

* add missing interface to pass through tracer.

* return SpanContext instead of contex.Context from Extract interface.
- also remove PassThroughTracer

* fix review comments.

* add more test cases for traceContext extraction.

* remove tidy temporarily from circle-ci target to avoid build failure.

* allow header ending in dash '-'.

* add inject test for non-zero value other than 01 for traceoption

* add AddLink and Link interface to MockSpan

* fix running go mod tidy on every build.
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants