-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation for github.com/graph-gophers/graphql-go #85
Comments
@MrAlias may I pick this up ? |
@ravilushqa @jay-manday @jjmengze @gtourkas |
@pellared In situation with @jjmengze, our pr's are both for a one lib. I'm not experienced contributor, so i'm not pretty sure how to deal with that. I'm pretty long waiting for it, and I will be happy if we will collaborate around it. My suggest is to contribute separately this one, and mine #761 :) |
@ravilushqa sufficiently described the case: this PR for for graph-gophers/graphql-go, which is also what the issue #85 is about, and the other two for 99designs/gqlgen . Apart from the registry item, which I guess is the last step, the PR is imo ready for review. |
In accordance with the new instrumentation policy hosting guidelines I'm closing this. |
* add propagation api. * add http propagator interface and w3c propagator implementation. * remove Extract api from trace. * remove Extract interface for tracer. * fix copyright. * fix variable names and comments. * move inject/extract out of trace. * replace INVALID_SPAN_CONTEXT with EmptySpanContext function. * fix tag.Map. * make carrier as interface instead of http.Request. * rename structs and update doc comments.. * add doc.go * update doc. * add noop propagator. * add new propagation api with Supplier interface. - added Default Tracer which simply propagates SpanContext. - added CopyOfRemote option to simply create remote span. * remove old propagator. * rename propagator to TextFormatPropagator. * rename default tracer/span as pass_through tracer/span. * add test for pass through tracer. * add missing interface to pass through tracer. * return SpanContext instead of contex.Context from Extract interface. - also remove PassThroughTracer * fix review comments. * add more test cases for traceContext extraction. * remove tidy temporarily from circle-ci target to avoid build failure. * allow header ending in dash '-'. * add inject test for non-zero value other than 01 for traceoption * add AddLink and Link interface to MockSpan * fix running go mod tidy on every build.
https://github.com/graph-gophers/graphql-go
Tasks
Dockerfile
with example app showing instrumentationPrior Art
The text was updated successfully, but these errors were encountered: