Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter support for new stats handlers #5248

Closed
Sovietaced opened this issue Mar 4, 2024 · 2 comments
Closed

Filter support for new stats handlers #5248

Sovietaced opened this issue Mar 4, 2024 · 2 comments
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc

Comments

@Sovietaced
Copy link
Contributor

Sovietaced commented Mar 4, 2024 •
edited
Loading

Problem Statement

WithInterceptorFilter was deprecated but there is no equivalent functionality for the new stats handlers. Personally I'd like to be able to ignore tracing/metrics for the health check API.

Proposed Solution

Implement filtering in stats handlers

Would be happy to contribute this, let me know!
@Sovietaced Sovietaced added area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc labels Mar 4, 2024
@dmathieu
Copy link
Member

dmathieu commented Mar 4, 2024

Duplicate of #4575

@dmathieu dmathieu marked this as a duplicate of #4575 Mar 4, 2024
@dmathieu dmathieu closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@Sovietaced
Copy link
Contributor Author

Sorry! Should have searched first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmathieu @Sovietaced