Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: stats handler doesn't seem to have an option for filtering #4575

Closed
anuraaga opened this issue Nov 13, 2023 · 3 comments · Fixed by #5196
Closed

otelgrpc: stats handler doesn't seem to have an option for filtering #4575

anuraaga opened this issue Nov 13, 2023 · 3 comments · Fixed by #5196
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working good first issue Good for newcomers instrumentation: otelgrpc
Milestone
untracked

Comments

@anuraaga
Copy link
Contributor

With the latest release, interceptors were deprecated from otelgrpc instrumentation. However, there doesn't seem to be an equivalent to WithInterceptorFilter which can filter spans (we use it to filter health checks filters.Not(filters.HealthCheck()). If there is a way that I missed, it likely needs to be added to the deprecation notice on WithInterceptorFilter.

https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/google.golang.org/grpc/otelgrpc/config.go#L149
@anuraaga anuraaga added area: instrumentation Related to an instrumentation package bug Something isn't working instrumentation: otelgrpc labels Nov 13, 2023
@anuraaga anuraaga changed the title Stats handler doesn't seem to have an option for filtering otelgrpc: stats handler doesn't seem to have an option for filtering Nov 13, 2023
@zchee zchee mentioned this issue Nov 27, 2023
Closed
@pgporada pgporada mentioned this issue Jan 3, 2024
Closed
@michaelbeaumont michaelbeaumont mentioned this issue Feb 29, 2024
Closed
5 tasks
@ymtdzzz ymtdzzz mentioned this issue Mar 3, 2024
Merged
@ymtdzzz
Copy link
Contributor

ymtdzzz commented Mar 3, 2024

I started this on #5196, but if anyone else has already worked on it, please let me know so I'll close it 😀

@dmathieu dmathieu mentioned this issue Mar 4, 2024
Closed
@mm2175
Copy link

mm2175 commented Mar 23, 2024

encouter same issue

@kperreau
Copy link

kperreau commented May 3, 2024

Any update on this issue?

@dmathieu dmathieu added the good first issue Good for newcomers label May 3, 2024
@thrawn01 thrawn01 mentioned this issue May 24, 2024
Merged
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working good first issue Good for newcomers instrumentation: otelgrpc
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

otelgrpc: Add Filter for stats handler ymtdzzz/opentelemetry-go-contrib
6 participants
@dmathieu @anuraaga @pellared @kperreau @mm2175 @ymtdzzz