Skip to content

Commit

Permalink
Count code owners approvals towards the two required approvals (#6675)
Browse files Browse the repository at this point in the history
  • Loading branch information
dmathieu authored Jan 23, 2025
1 parent 85f9766 commit e6b3142
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Changes should be made using [the GitHub flow](https://guides.github.com/introdu

A pull request is considered ready to merge when the following criteria are meet.

* It has received two approvals from Approvers/Maintainers (at different companies), unless the change is for an exempt module[^1].
* It has received two approvals from Code Owners/Approvers/Maintainers (at different companies), unless the change is for an exempt module[^1].
* All feedback has been addressed. Be sure to "Resolve" all comments that have been addressed to signal this.
* Any substantive changes submitted after an Approval removes that Approval.
You will need to manually clear these prior Approval reviews to indicate to the reviewer that they need to resubmit their review.
Expand Down

0 comments on commit e6b3142

Please sign in to comment.