-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End-to-end example applications #936
Merged
cijothomas
merged 37 commits into
open-telemetry:master
from
alanwest:alanwest/end-to-end-example
Aug 10, 2020
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
41b1921
Suite of example applications demonstrating context propagation with …
alanwest d899d2a
Put System.* namespaces first
alanwest d3b2e51
Newline at EOF
alanwest 203cad3
Fix markdownlint errors
alanwest 38a2a5b
markdownlint fix
alanwest 5fc6e6f
Merge branch 'master' into alanwest/end-to-end-example
cijothomas c75f113
Merge branch 'master' into alanwest/end-to-end-example
cijothomas bbbdb09
Merge branch 'master' into alanwest/end-to-end-example
cijothomas 0ab8939
Refactor WorkerService separating OpenTelemetry related logic from Ra…
alanwest b58a421
Refactor WebApi separating OpenTelemetry related logic from RabbitMQ …
alanwest 5248c04
Use environment variables for RabbitMQ user/pass
alanwest 834503e
Add some comments
alanwest 6191d9d
Merge remote-tracking branch 'upstream/master' into master
alanwest c38f060
Merge branch 'master' into alanwest/end-to-end-example
alanwest 225fadf
Fix RabbitMQ default user/pass
alanwest ba436f0
Use correct ActivityKind
alanwest 403faae
Add attributes following messaging specification
alanwest 59da6cd
Clearing a path through the RabbitMQ jungle
alanwest b1e5de9
Merge branch 'master' into alanwest/end-to-end-example
alanwest 9682076
Merge branch 'master' into alanwest/end-to-end-example
alanwest 4d51283
Merge branch 'master' into alanwest/end-to-end-example
alanwest c925fa2
Merge branch 'master' into alanwest/end-to-end-example
alanwest 807d0ea
Log something when sending/receiving a message
alanwest c2d0484
Code style clean up
alanwest 413a56b
Default logging to info level
alanwest de660c6
Create queue if it does not exist
alanwest a647188
Rename controller to SendMessageController
alanwest c38945d
Refine the readme
alanwest 7f0de78
MarkdownCop
alanwest bbdb926
Merge branch 'master' into alanwest/end-to-end-example
CodeBlanch 0d1a90a
Merge branch 'master' into alanwest/end-to-end-example
alanwest ccc0847
Fix merge snafu
alanwest 51784cf
Merge branch 'alanwest/end-to-end-example' of github.com:alanwest/ope…
alanwest 437a990
Add null checks on activity
alanwest 2d8bade
Add a missed null check
alanwest dcf093a
Use AddOpenTelemetry in ConfigureServices
alanwest dc654ad
Merge branch 'master' into alanwest/end-to-end-example
cijothomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add attributes following messaging specification
- Loading branch information
commit 403faaeff648f14399399a8df26224da63fc0239
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some other semantic tags we could demo here, like
messaging.system
,messaging.destination
,messaging.destination_kind
. Might be useful to show a mix of semantic tags and custom ones?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes all good suggestions. I also noted that the spec calls out some special considerations for RabbitMQ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh. I haven't noticed that special RabbitMQ rule before, I'm going to have to fix some stuff IRL 😆