Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect as usage in MessageReceiver #6105

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

as should only be used when unsure of the type and then a null check must follow it. in this case i assume since there is no null check, the type is therefore known, and a direct cast will prevent a potential null ref exception

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 27, 2025 00:00
@github-actions github-actions bot added the documentation Documentation related label Jan 27, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (89ea5c6) to head (8989b3f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6105   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files         257      257           
  Lines       11640    11640           
=======================================
  Hits        10056    10056           
  Misses       1584     1584           

@rajkumar-rangaraj rajkumar-rangaraj merged commit cccf1ec into open-telemetry:main Jan 31, 2025
30 checks passed
@SimonCropp SimonCropp deleted the fix-incorrect-as-usage-in-MessageReceiver branch February 1, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants