Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] Small cleanup/simplification #6048

Merged
merged 7 commits into from
Feb 8, 2025
Merged

[repo] Small cleanup/simplification #6048

merged 7 commits into from
Feb 8, 2025

Conversation

pentp
Copy link
Contributor

@pentp pentp commented Jan 6, 2025 •
edited
Loading

Some basic cleanup and simplification.

@pentp pentp requested a review from a team as a code owner January 6, 2025 09:58
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 6, 2025
@CodeBlanch
Copy link
Member

@pentp There's some stuff on here I would be happy to merge. Like adding readonly or simplifying lambdas, etc. There's other stuff I think we need to look at more closely like switching from Interlocked to Volatile. Would you be willing to split up this PR?

@pentp pentp mentioned this pull request Jan 8, 2025
Open
@CodeBlanch CodeBlanch changed the title Small metrics handling optimizations/cleanup [repo] Small cleanup/simplification Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added Stale Issues and pull requests which have been flagged for closing due to inactivity and removed Stale Issues and pull requests which have been flagged for closing due to inactivity labels Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 26, 2025
@Kielek Kielek requested a review from CodeBlanch January 27, 2025 05:32
@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Jan 28, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (0c26ce2) to head (2901157).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6048      +/-   ##
==========================================
- Coverage   86.37%   86.36%   -0.02%     
==========================================
  Files         257      257              
  Lines       11622    11584      -38     
==========================================
- Hits        10039    10005      -34     
+ Misses       1583     1579       -4
Files with missing lines Coverage Δ
...endencyInjectionLoggerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...pendencyInjectionMeterProviderBuilderExtensions.cs 100.00% <ø> (ø)
...endencyInjectionTracerProviderBuilderExtensions.cs 100.00% <ø> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 80.64% <ø> (-0.61%) ⬇️
src/OpenTelemetry.Api/Trace/TracerProvider.cs 93.75% <ø> (-0.19%) ⬇️
...torage/PersistentStorageAbstractionsEventSource.cs 40.00% <ø> (-10.00%) ⬇️
.../PersistentStorage/PersistentStorageEventSource.cs 44.89% <ø> (-1.11%) ⬇️
...ing/Implementation/HostingExtensionsEventSource.cs 100.00% <ø> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 79.13% <ø> (-0.18%) ⬇️
src/OpenTelemetry/Logs/LogRecord.cs 70.19% <ø> (-0.59%) ⬇️
... and 7 more

@rajkumar-rangaraj rajkumar-rangaraj merged commit 71abd41 into open-telemetry:main Feb 8, 2025
39 checks passed
@pentp pentp deleted the small-opts branch February 8, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuijben rhuijben rhuijben left review comments

@Kielek Kielek Kielek approved these changes

@rajkumar-rangaraj rajkumar-rangaraj rajkumar-rangaraj approved these changes

@CodeBlanch CodeBlanch Awaiting requested review from CodeBlanch

Assignees
No one assigned
Labels
pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pentp @CodeBlanch @rhuijben @Kielek @rajkumar-rangaraj