-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Implement Span and SpanLink flags #5563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
==========================================
+ Coverage 83.38% 85.58% +2.19%
==========================================
Files 297 289 -8
Lines 12531 12500 -31
==========================================
+ Hits 10449 10698 +249
+ Misses 2082 1802 -280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stevejgordon
force-pushed
the
implement-flags
branch
from
April 23, 2024 08:02
93b7300
to
9d60b70
Compare
andreycha
reviewed
Apr 23, 2024
vishweshbankwar
approved these changes
Apr 23, 2024
Kielek
approved these changes
Apr 23, 2024
rajkumar-rangaraj
approved these changes
Apr 23, 2024
CodeBlanch
changed the title
Implement OTLP
[otlp] Implement Apr 23, 2024
Span
and SpanLink
flagsSpan
and SpanLink
flags
CodeBlanch
changed the title
[otlp] Implement
[otlp] Implement Span and SpanLink flags
Apr 23, 2024
Span
and SpanLink
flags
CodeBlanch
added
the
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
label
Apr 23, 2024
CodeBlanch
reviewed
Apr 23, 2024
CodeBlanch
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implementation to populate the flags field when exporting a
Span
orSpanLink
through OTLP, including the W3C trace flags andparent_is_remote
flags specification.See:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes* [ ] Changes in public API reviewed (if applicable)