Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Implement Span and SpanLink flags #5563

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

stevejgordon
Copy link
Contributor

Changes

Implementation to populate the flags field when exporting a Span or SpanLink through OTLP, including the W3C trace flags and parent_is_remote flags specification.

See:

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
    * [ ] Changes in public API reviewed (if applicable)

@stevejgordon stevejgordon requested a review from a team April 23, 2024 07:55
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.58%. Comparing base (6250307) to head (42e4362).
Report is 189 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5563      +/-   ##
==========================================
+ Coverage   83.38%   85.58%   +2.19%     
==========================================
  Files         297      289       -8     
  Lines       12531    12500      -31     
==========================================
+ Hits        10449    10698     +249     
+ Misses       2082     1802     -280     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.30% <100.00%> (?)
unittests-Solution-Stable 85.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...metryProtocol/Implementation/ActivityExtensions.cs 96.08% <100.00%> (+0.15%) ⬆️

... and 79 files with indirect coverage changes

@CodeBlanch CodeBlanch changed the title Implement OTLP Span and SpanLink flags [otlp] Implement Span and SpanLink flags Apr 23, 2024
@CodeBlanch CodeBlanch changed the title [otlp] Implement Span and SpanLink flags [otlp] Implement Span and SpanLink flags Apr 23, 2024
@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Apr 23, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit efe97bf into open-telemetry:main Apr 23, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants