[integration test] otlp log exporter #4854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4854 +/- ##
==========================================
- Coverage 83.96% 83.93% -0.03%
==========================================
Files 293 293
Lines 12021 12023 +2
==========================================
- Hits 10093 10092 -1
- Misses 1928 1931 +3
|
added 2 commits
September 15, 2023 10:12
…ub.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-otlp-log-integration-test
…ub.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-otlp-log-integration-test
CodeBlanch
reviewed
Sep 15, 2023
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpLogExporterHelperExtensions.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Sep 15, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTest/IntegrationTests.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Sep 18, 2023
| var otlpExporter = new OtlpLogExporter(exporterOptions); | ||
| BaseExporter<LogRecord> otlpExporter = new OtlpLogExporter(exporterOptions); | ||
|
|
||
| if (configureExporterInstance != null) |
There was a problem hiding this comment.
nit: Simplify this by using configureExporterInstance?.Invoke(otlpExporter).
utpilla
reviewed
Sep 18, 2023
| var otlpExporter = new OtlpLogExporter(exporterOptions); | ||
| BaseExporter<LogRecord> otlpExporter = new OtlpLogExporter(exporterOptions); | ||
|
|
||
| if (configureExporterInstance != null) |
There was a problem hiding this comment.
Add a comment that this option is only used by tests.
utpilla
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration test for otlp log exporter + some refactoring to enable testing + minor fix for example