Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct SDK EventSource method to log invalid environment variable #4649

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jul 12, 2023

Related to #4516

This PR sets the correct method to be used to log when the SDK runs into an invalid environment variable read in the Configuration extension method: TryGetIntValue.

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team July 12, 2023 01:02
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #4649 (d08b226) into main (f95c689) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d08b226 differs from pull request most recent head 213e99c. Consider uploading reports for the commit 213e99c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4649      +/-   ##
==========================================
+ Coverage   84.97%   85.00%   +0.02%     
==========================================
  Files         314      314              
  Lines       12685    12689       +4     
==========================================
+ Hits        10779    10786       +7     
+ Misses       1906     1903       -3     
Impacted Files Coverage Δ
src/OpenTelemetry/Sdk.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@utpilla utpilla merged commit d2b269a into open-telemetry:main Jul 12, 2023
@utpilla utpilla deleted the utpilla/Update-OpenTelemetry-Sdk-For-ConfigurationExtensions branch November 23, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants