Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CVE-2023-32731 #4647

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Resolve CVE-2023-32731 #4647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab4ce47
Resolve CVE-2023-32731
reyang Jul 10, 2023
7e91b29
add the PR number
reyang Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<ItemGroup>
<PackageVersion Include="Google.Protobuf" Version="[3.19.4,4.0)" />
<PackageVersion Include="Grpc" Version="[2.44.0,3.0)" />
<PackageVersion Include="Grpc.Net.Client" Version="[2.45.0,3.0)" />
<PackageVersion Include="Grpc.Net.Client" Version="[2.52.0,3.0)" />
Copy link
Member

@alanwest alanwest Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure 2.52.0 contains the fix? Based on the PR you reference, it looks like when it was merged its commit is tagged with 2.53.0 grpc/grpc@29d8bee

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my mistake the fix was the PR is against the core grpc repo not Grpc.Net.Client.

Copy link
Contributor

@utpilla utpilla Jul 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.52.0 is also the lowest available version of the package with no known vulnerabilities.

https://www.nuget.org/packages/Grpc.Net.Client

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.nuget.org/packages/Grpc.Net.Client this is the one we'll be using.
I guess the general rule here is to reference the lowest version that is not deprecated?

image

<PackageVersion Include="Grpc.Tools" Version="[2.44.0,3.0)" />
<PackageVersion Include="Microsoft.AspNetCore.Http.Abstractions" Version="[2.1.1,6.0)" />
<PackageVersion Include="Microsoft.AspNetCore.Http.Features" Version="[2.1.1,6.0)" />
Expand Down
8 changes: 7 additions & 1 deletion src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,19 @@
for instructions to enable exemplars.
([#4553](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4553))

* Updated Grpc.Net.Client to v2.45 to fix unobserved exception
* Updated Grpc.Net.Client to `2.45.0` to fix unobserved exception
from failed calls.
([#4573](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4573))

* Updated to support `Severity` and `SeverityText` when exporting `LogRecord`s.
([#4568](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4568))

* Updated Grpc.Net.Client to `2.52.0` to address the vulnerability reported by
CVE-2023-32731. Refer to
[https://github.com/grpc/grpc/pull/32309](https://github.com/grpc/grpc/pull/32309)
for more details.
([#4647](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4647))

## 1.5.1

Released 2023-Jun-26
Expand Down