Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseOtlpExporterOptions #4391

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Apr 14, 2023

Towards #4388
Design discussion issue #

Changes

This PR introduces a new class BaseOtlpExporterOptions. Options that are common across all 3 signals are moved here.

OtlpExporterOptions will now only contain two options ExportProcessorType and BatchExportProcessorOptions.

Will add OtlpLogExporterOptions in follow up PR.

Open question:

  1. Should we include ExportProcessorType and BatchExportProcessorOptions for OtlpLogExporterOptions?
    OR
    Should we update the extension methods for adding log exporter to include these? ExporterOptions should not control the pipeline #2552

e.g.

AddOtlpExporterInternal(OpenTelemetryLoggerOptions loggerOptions, 
Action<OtlpLogExporterOptions, BatchLogExportProcessorOptions> configureExporterAndBatchProcessor)`

similar to what we have on metrics

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #4391 (7b2df46) into main (7958763) will increase coverage by 0.04%.
The diff coverage is 95.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4391      +/-   ##
==========================================
+ Coverage   84.73%   84.78%   +0.04%     
==========================================
  Files         300      301       +1     
  Lines       12010    12010              
==========================================
+ Hits        10177    10183       +6     
+ Misses       1833     1827       -6     
Impacted Files Coverage Δ
...r.OpenTelemetryProtocol/BaseOtlpExporterOptions.cs 95.34% <95.34%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (+3.63%) ⬆️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 96.80% <100.00%> (ø)

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant