Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] ResourceBuilder AddDetector public API tweak #3997

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

CodeBlanch
Copy link
Member

Relates to #3782

Changes

  • During API review for 1.4 release we decided to make this API internal.

@CodeBlanch CodeBlanch requested a review from a team December 9, 2022 17:55
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #3997 (20b1723) into main (723ad0b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3997      +/-   ##
==========================================
- Coverage   85.40%   85.39%   -0.01%     
==========================================
  Files         289      289              
  Lines       11228    11236       +8     
==========================================
+ Hits         9589     9595       +6     
- Misses       1639     1641       +2     
Impacted Files Coverage Δ
src/OpenTelemetry/Resources/ResourceBuilder.cs 89.79% <ø> (ø)
...ation.SqlClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...p/Implementation/HttpInstrumentationEventSource.cs 72.00% <0.00%> (-4.00%) ⬇️

@CodeBlanch CodeBlanch merged commit 6c47447 into open-telemetry:main Dec 9, 2022
@CodeBlanch CodeBlanch deleted the public-api-AddDetector branch December 9, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants