Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs + Traces] Add named options support to ConsoleExporter builder extensions #3657

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Sep 13, 2022

Changes

Applies the named options pattern from #3648 to ConsoleExporter logger & tracer builder extensions.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team September 13, 2022 22:06
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #3657 (fc0807d) into main (cb2eeb5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         283      283           
  Lines       10243    10243           
=======================================
  Hits         8996     8996           
  Misses       1247     1247           
Impacted Files Coverage Δ
...Propagators/OpenTelemetryPropagatorsEventSource.cs 87.50% <0.00%> (-12.50%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 78.04% <0.00%> (-2.44%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 76.47% <0.00%> (+2.94%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@CodeBlanch CodeBlanch merged commit 11c804a into open-telemetry:main Sep 13, 2022
@CodeBlanch CodeBlanch deleted the consoleexporter-logs-traces-namedoptions branch September 13, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants