Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Moq with InMemoryExporter in ASP.NET Core #3328

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Replace Moq with InMemoryExporter in ASP.NET Core #3328

merged 2 commits into from
Jun 2, 2022

Conversation

cijothomas
Copy link
Member

More towards #2534

@cijothomas cijothomas requested a review from a team June 2, 2022 00:07
@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #3328 (88840e9) into main (0b09346) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
+ Coverage   85.42%   85.43%   +0.01%     
==========================================
  Files         269      269              
  Lines        9552     9552              
==========================================
+ Hits         8160     8161       +1     
+ Misses       1392     1391       -1
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-8.83%) ⬇️
...orter.InMemory/InMemoryExporterHelperExtensions.cs 100.00% <0.00%> (+50.00%) ⬆️

alanwest
alanwest approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 05feb69 into open-telemetry:main Jun 2, 2022
@cijothomas cijothomas deleted the cijothomas/inmemoryexporter branch August 15, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cijothomas @alanwest