Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net461 from OpenTracing shim #3224

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

cijothomas
Copy link
Member

#3190 leftover

@cijothomas cijothomas requested a review from a team April 22, 2022 05:55
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #3224 (14c6f2c) into main (e35216a) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
+ Coverage   85.69%   85.72%   +0.03%     
==========================================
  Files         260      260              
  Lines        9366     9366              
==========================================
+ Hits         8026     8029       +3     
+ Misses       1340     1337       -3     
Impacted Files Coverage Δ
...metryProtocol/Implementation/ActivityExtensions.cs 92.34% <0.00%> (+0.90%) ⬆️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Here are a few more leftovers:

We can now remove the whole except for versions lower than fragments as AFAIK we will be supporting all supported .NET versions 😉

@cijothomas
Copy link
Member Author

We can now remove the whole except for versions lower than fragments as AFAIK we will be supporting all supported .NET versions 😉

Except .NET Framework 3.5 🤣

@cijothomas cijothomas merged commit 5c0ad88 into open-telemetry:main Apr 22, 2022
@cijothomas cijothomas deleted the cijothomas/shim_remove461 branch April 22, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants