Dev/twegner/spankindaddition #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging open-telemetry/opentelemetry-dotnet master
lmolkova
reviewed
May 14, 2019
src/OpenTelemetry.Exporter.ApplicationInsights/Implementation/TraceExporterHandler.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 14, 2019
src/OpenTelemetry.Exporter.ApplicationInsights/Implementation/TraceExporterHandler.cs
Show resolved
Hide resolved
lmolkova
reviewed
May 14, 2019
src/OpenTelemetry.Exporter.Ocagent/Implementation/SpanDataExtentions.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 14, 2019
src/OpenTelemetry.Exporter.Zipkin/Implementation/TraceExporterHandler.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 14, 2019
...OpenTelemetry.Exporter.ApplicationInsights.Tests/Implementation/TraceExporterHandlerTests.cs
Outdated
Show resolved
Hide resolved
SergeyKanzhelev
approved these changes
May 14, 2019
There was a problem hiding this comment.
I also created #31 in the same area. You can address together or as a separate PR
src/OpenTelemetry.Exporter.Ocagent/Implementation/SpanDataExtentions.cs
Outdated
Show resolved
Hide resolved
|
I will close and re-open so CLA will get applied |
|
Please sign CLA and update the branch! Thank you! |
|
@trwegner you used two different e-mails to push commits - one (at)Microsoft and another (at)hotmail. Please use one that you signed CLA with. It should solve the problem |
PR feedback and change Unspecified to Internal to address #31
…egner/opentelemetry-dotnet into dev/twegner/spankindaddition
|
Closing to address commits from different identities. Will resubmit once resolved. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding producer and consumer SpanKind to address #8
Only Zipkin exporter currently support for the new values directly, other exportes will map producer to server and consumer to client.
Other changes address #15 and #31